Skip to content

Feat: added lovable icon #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2025
Merged

Feat: added lovable icon #378

merged 2 commits into from
Oct 27, 2025

Conversation

@HarshMN2345
Copy link
Member

@HarshMN2345 HarshMN2345 commented Oct 27, 2025 •
edited by coderabbitai bot
Loading

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Summary by CodeRabbit

  • Chores

    • Updated CI/CD pipeline to use Node.js 20 and PNPM for improved performance and consistency
    • Added new GitHub Actions workflow for automated package publishing
    • Enhanced project configuration with standardized formatting and npm settings
    • Updated Docker build context to optimize image sizes

  • Revert

    • Removed demo application from repository

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6ca319c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package or glob expression "@appwrite.io/pink" specified in the `linked` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@appwrite.io/pink-icons" specified in the `linked` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@appwrite.io/kitchensink" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@appwrite.io/fonts" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@appwrite.io/pink-design" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@appwrite
Copy link

appwrite bot commented Oct 27, 2025 •
edited
Loading

Pink

Project ID: 688b850d003678e26eb4

Sites (1)
Site Status Logs Preview QR
 pink
688b852d002905ceebe1		 Ready Ready View Logs Preview URL QR Code

Tip

Appwrite has a Discord community with over 16 000 members.

@HarshMN2345 HarshMN2345 changed the base branch from main to next October 27, 2025 11:48
@coderabbitai
Copy link

coderabbitai bot commented Oct 27, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This pull request performs a significant project restructuring involving configuration updates and removal of demo content. Root-level configuration files are added or modified (.npmrc, .prettierrc, .gitignore, .dockerignore), including npm engine settings and Prettier formatting rules. The CI/CD workflows are updated (.github/workflows/tests.yml reworked for pnpm and Node.js 20, new pkg-vc.yml workflow added for publishing packages). The entire apps/kitchensink demo application is systematically removed, including all HTML pages, CSS, JavaScript, build configuration, package manifest, and Handlebars partials. The .stylelintrc.json file is also deleted.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

  • Workflow changes: Review .github/workflows/tests.yml for pnpm migration, Node version bump, and artifact handling logic
  • New pkg-vc workflow: Verify publish-action configuration, organization settings, and package paths in .github/workflows/pkg-vc.yml
  • Configuration changes: Validate .npmrc engine-strict and peer dependency settings, .prettierrc formatting rules, and .dockerignore patterns for their intended project requirements
  • Kitchensink removal: Verify intentionality of wholesale demo app removal across ~40 files; confirm no critical functionality is being lost
  • Root .gitignore additions: Confirm .zed and .vscode are appropriate editor directories to ignore

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The PR title "Feat: added lovable icon" does not align with the substantive changes shown in the raw summary. The changeset predominantly consists of deletions of the entire apps/kitchensink/ application (including dozens of HTML demo pages, configuration files like package.json, vite.config.js, and main.js), along with updates to repository-level configuration files and CI/CD workflows. There is no mention of adding any icon, let alone a "lovable icon," anywhere in the file-level summaries. The title describes a feature addition that does not appear to be present in the changeset. The PR title should be revised to accurately reflect the main purpose of the changeset. If this PR is intended to remove the kitchensink demo application and restructure the project, a more appropriate title would describe that reorganization. If the PR was intended to add a lovable icon, this appears to be the wrong changeset, and the title should either be corrected or the changes should be verified against the intended scope.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025 •
edited
Loading

🚀 Previews available on pkg.vc!

📦 @appwrite.io/pink-svelte

Install @appwrite.io/pink-svelte with:

pnpm install https://pkg.vc/-/@appwrite/@appwrite.io/pink-svelte@6ca319c

Alternatively, you may specify a branch name or pull request number:

pnpm install https://pkg.vc/-/@appwrite/@appwrite.io/pink-svelte~feat-lovable-icon
pnpm install https://pkg.vc/-/@appwrite/@appwrite.io/pink-svelte!378

📦 @appwrite.io/pink-icons-svelte

Install @appwrite.io/pink-icons-svelte with:

pnpm install https://pkg.vc/-/@appwrite/@appwrite.io/pink-icons-svelte@6ca319c

Alternatively, you may specify a branch name or pull request number:

pnpm install https://pkg.vc/-/@appwrite/@appwrite.io/pink-icons-svelte~feat-lovable-icon
pnpm install https://pkg.vc/-/@appwrite/@appwrite.io/pink-icons-svelte!378

@HarshMN2345 HarshMN2345 merged commit fc3a419 into next Oct 27, 2025
3 of 4 checks passed
@HarshMN2345 HarshMN2345 deleted the feat-lovable-icon branch October 27, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ItzNotABug ItzNotABug ItzNotABug approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HarshMN2345 @ItzNotABug