Skip to content

Fix: replaced svelte icon #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2025
Merged

Fix: replaced svelte icon #380

merged 1 commit into from
Oct 29, 2025

Conversation

@HarshMN2345
Copy link
Member

@HarshMN2345 HarshMN2345 commented Oct 29, 2025 •
edited by coderabbitai bot
Loading

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Summary by CodeRabbit

Release Notes

  • Chores

    • Updated project configuration for Docker containerization and npm package management
    • Migrated build toolchain to use pnpm package manager across all workflows
    • Removed kitchen sink demo application
    • Added standardized code formatting rules

  • Tests

    • Enhanced CI/CD pipeline with improved testing workflow and artifact reporting

  • New Features

    • Added automated package publishing to registry on pull requests

@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2025

⚠️ No Changeset found

Latest commit: 976f4b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package or glob expression "@appwrite.io/pink" specified in the `linked` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@appwrite.io/pink-icons" specified in the `linked` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@appwrite.io/kitchensink" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@appwrite.io/fonts" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@appwrite.io/pink-design" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@appwrite
Copy link

appwrite bot commented Oct 29, 2025 •
edited
Loading

Pink

Project ID: 688b850d003678e26eb4

Sites (1)
Site Status Logs Preview QR
 pink
688b852d002905ceebe1		 Ready Ready View Logs Preview URL QR Code

Tip

Appwrite has a Discord community with over 16 000 members.

@coderabbitai
Copy link

coderabbitai bot commented Oct 29, 2025 •
edited
Loading

Caution

Review failed

Failed to post review comments

Walkthrough

This PR modernizes project tooling and removes the kitchensink demo application. Changes include: adding Docker configuration (.dockerignore), updating Git ignore patterns, adding npm strictness and package linking configurations, establishing Prettier formatting standards, and removing Stylelint. GitHub Actions workflows are migrated from npm to PNPM with a new pkg.vc publication workflow added. The entire apps/kitchensink directory is removed, eliminating all demo HTML pages, styling, JavaScript, Vite configuration, package manifest, and Handlebars templates.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

  • Multiple workflow updates: GitHub Actions workflows (.github/workflows/pkg-vc.yml and tests.yml) introduce new pipeline logic with PNPM tooling, artifact handling, and publication steps requiring careful validation
  • Extensive directory removal: Large volume of deletions across apps/kitchensink (50+ files) including HTML, styles, scripts, and configuration files—while individually low-complexity, the quantity and scope demand verification of intentionality
  • Configuration changes across multiple domains: Updates to Docker, npm, Prettier, and Git configuration require cross-verification for compatibility
  • Tooling migration: Transition from npm to PNPM in workflows and lock file handling needs validation

Areas requiring extra attention:

  • .github/workflows/pkg-vc.yml — validate package paths, secret usage, and publish action configuration
  • .github/workflows/tests.yml — ensure PNPM migration is complete, artifact naming/retention policy, and test execution flow
  • .npmrc changes — verify compatibility of engine-strict, legacy-peer-deps, and node-linker settings with project dependencies
  • apps/kitchensink removal — confirm this is intentional deprecation and not accidental deletion

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The PR title "Fix: replaced svelte icon" is misleading and does not accurately reflect the main changes in the changeset. While the new GitHub workflow file references Svelte packages (@appwrite.io/pink-svelte and @appwrite.io/pink-icons-svelte), the overwhelming majority of the changes consist of deleting the entire apps/kitchensink directory with its 40+ HTML files, CSS, JavaScript, configuration files, and partials. The PR also includes significant configuration additions and modifications (.npmrc, .prettierrc, workflow files, etc.). The title suggests a minor icon replacement fix, which is unrelated to the actual scope of these substantial changes. The PR title should be revised to accurately reflect the primary changes. A more appropriate title would describe the main action: for example, "Remove kitchensink demo app and add package publishing workflows" or similar phrasing that captures both the deletion of the kitchensink directory and the addition of CI/CD infrastructure for publishing packages. The current title is insufficient for a teammate scanning pull request history to understand what was done.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-svelte-icon

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@HarshMN2345 HarshMN2345 changed the base branch from main to next October 29, 2025 10:38
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025 •
edited
Loading

🚀 Previews available on pkg.vc!

📦 @appwrite.io/pink-svelte

Install @appwrite.io/pink-svelte with:

pnpm install https://pkg.vc/-/@appwrite/@appwrite.io/pink-svelte@976f4b6

Alternatively, you may specify a branch name or pull request number:

pnpm install https://pkg.vc/-/@appwrite/@appwrite.io/pink-svelte~fix-svelte-icon
pnpm install https://pkg.vc/-/@appwrite/@appwrite.io/pink-svelte!380

📦 @appwrite.io/pink-icons-svelte

Install @appwrite.io/pink-icons-svelte with:

pnpm install https://pkg.vc/-/@appwrite/@appwrite.io/pink-icons-svelte@976f4b6

Alternatively, you may specify a branch name or pull request number:

pnpm install https://pkg.vc/-/@appwrite/@appwrite.io/pink-icons-svelte~fix-svelte-icon
pnpm install https://pkg.vc/-/@appwrite/@appwrite.io/pink-icons-svelte!380

@HarshMN2345 HarshMN2345 merged commit 460d19b into next Oct 29, 2025
6 of 7 checks passed
@HarshMN2345 HarshMN2345 deleted the fix-svelte-icon branch October 29, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ItzNotABug ItzNotABug ItzNotABug approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HarshMN2345 @ItzNotABug