Avoid OOM and speed up training in SOS circuits #330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other changes:
TorchCircuit.device()property and the._set_device()method for two reasons. First, modules are NOT stored on devices, but tensors are. Second, when the circuit is a sub-module in some other module, then its device was NOT updated when calling.to()to the parent module. This is because.to()is applied recursively to the tensors (buffers & parameters) but not modules. This broke the implementation of SOS circuits.