KF-25 add tests for EncodingDetector#43
Merged
Merged
Conversation
b907550 to
66f7482
Compare
66f7482 to
33ae9ea
Compare
belyshevdenis
approved these changes
Aug 13, 2025
SergiusTheBest
requested changes
Aug 13, 2025
SergiusTheBest
approved these changes
Aug 13, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for the EncodingDetector class, which identifies text encodings from byte buffers. The tests cover both BOM-based detection and heuristic-based detection scenarios.
- Adds a new test file with 183 lines covering various encoding detection scenarios
- Updates the CMake build configuration to include the new test file
- Minor documentation and initialization improvements to the EncodingDetector header
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/EncodingDetectorTest.cpp | New comprehensive test suite covering BOM detection for UTF-8/16/32 variants and non-BOM scenarios |
| test/CMakeLists.txt | Adds the new test file to the build configuration |
| include/kf/EncodingDetector.h | Adds class documentation and improves member initialization |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
SergiusTheBest
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: https://jira.dev.local/jira/browse/KF-25