Skip to content

KF- 25 add tests for Hex#44

Merged
SergiusTheBest merged 4 commits into
mainfrom
KF-25-test-Hex
Aug 20, 2025
Merged

KF- 25 add tests for Hex#44
SergiusTheBest merged 4 commits into
mainfrom
KF-25-test-Hex

Conversation

@Kellesi
Copy link
Copy Markdown
Collaborator

@Kellesi Kellesi commented Aug 11, 2025

@Kellesi Kellesi requested a review from SergiusTheBest August 12, 2025 10:16
Comment thread test/HexTest.cpp Outdated
Comment thread test/HexTest.cpp Outdated
Comment thread test/HexTest.cpp Outdated
Comment thread test/HexTest.cpp Outdated
Copy link
Copy Markdown
Member

@SergiusTheBest SergiusTheBest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's break it into separate test cases, so it will be more readable and manageable. Also don't forget to mark constants.

@Kellesi
Copy link
Copy Markdown
Collaborator Author

Kellesi commented Aug 18, 2025

Let's break it into separate test cases, so it will be more readable and manageable. Also don't forget to mark constants.

Separated into different test cases. Also added missing test for invalid characters

@SergiusTheBest SergiusTheBest merged commit 83448bc into main Aug 20, 2025
2 checks passed
@SergiusTheBest SergiusTheBest deleted the KF-25-test-Hex branch August 20, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants