KF-29 add tests for Observer#46
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for the Observer pattern implementation by introducing a new test file with multiple test scenarios.
- Adds ObserverTest.cpp with test scenarios covering attach, detach, notify, and multiple notification functionality
- Updates CMakeLists.txt to include the new test file in the build
- Adds necessary include for cassert in Observer.h header
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/ObserverTest.cpp | New comprehensive test file for Observer pattern with scenarios testing attachment, notification, detachment, and multiple notifications |
| test/CMakeLists.txt | Adds ObserverTest.cpp to the test build configuration |
| include/kf/patterns/Observer.h | Adds cassert include dependency |
SergiusTheBest
requested changes
Aug 11, 2025
SergiusTheBest
requested changes
Aug 13, 2025
SergiusTheBest
requested changes
Aug 14, 2025
SergiusTheBest
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: https://jira.dev.local/jira/browse/KF-29