Fix bugs in process_j312.sh#100
Merged
Merged
Conversation
Contributor
Author
|
block merging until #103 is resolved. |
abachma2
reviewed
Jan 25, 2022
abachma2
left a comment
Contributor
There was a problem hiding this comment.
Overall this looks good. I did try this out and it does work well. I just have the one question about JEFF versions.
Comment on lines
+35
to
+39
| # Get neutron induced and spontaneous fission yield data from JEFF 3.3 | ||
| if [[ ! -f $DATADIR/sss_jeff33.nfy ]] | ||
| then | ||
| wget -O $DATADIR/sss_jeff33.nfy https://www.oecd-nea.org/dbdata/jeff/jeff33/downloads/JEFF33-nfy.asc | ||
| fi |
Contributor
There was a problem hiding this comment.
Does this pull data from JEFF 3.3? I thought this was for getting data from JEFF 3.1.2 ???
Contributor
Author
There was a problem hiding this comment.
There is no spontaneous or delayed neutron fission data in JEFF 3.1.2, nor is there decay data. The data from the JEFF 3.3 library is backwards compatible with the JEFF 3.1.2 library.
Contributor
There was a problem hiding this comment.
That makes sense. Just wanted to clarify the reason for the version change.
github-actions Bot
pushed a commit
to yardasol/saltproc
that referenced
this pull request
Jan 29, 2022
…j312 Fix bugs in `process_j312.sh` 88c5c94
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR fixes the bugs described in #99
This PR also renames
process_j312.shtoprocess_j312.bashto clarify that the script usesbashsyntax, and will not work properly (or even fail) when run as a native shell script.This PR also adds detection of existing compressed cross section library files, neutron data files, and decay chain file to reduce time it takes to rerun the script by skipping the download commands.
Types of changes
Required for Merging
Associated Issues and PRs
process_j312.sh#99Associated Developers
Checklist for Reviewers
Reviewers should use this link to get to the
Review Checklist before they begin their review.