Skip to content

bump sdk to latest + fix e2e #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
altafan merged 2 commits into from
Oct 28, 2025
Merged

bump sdk to latest + fix e2e #779

altafan merged 2 commits into from
Oct 28, 2025

Conversation

@louisinger
Copy link
Collaborator

@louisinger louisinger commented Oct 23, 2025 •
edited by coderabbitai bot
Loading

@altafan please review

Summary by CodeRabbit

  • Chores

    • Updated core dependencies to newer releases to keep the CLI and SDK current.

  • Tests

    • Improved end-to-end tests for sweep and recovery flows; validations now more precisely assert spendable vs spent output states and ensure recovered outputs are marked and swept as expected.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 23, 2025 •
edited
Loading

Walkthrough

Bumps ark-lib and go-sdk dependency versions in root and pkg/ark-cli go.mod files. Adjusts TestSweepBatchOutput in test/e2e/e2e_test.go to separately handle spendable vs spent VTXOs and adds assertions validating spend/recovery state.

Changes

Cohort / File(s) Summary
Dependency version updates
go.mod, pkg/ark-cli/go.mod		 Updated ark-lib from v0.7.2-0.20251019021702-9f025345fd28 to v0.7.2-0.20251020193908-f401a905e83f; updated go-sdk from v0.7.2-0.20251020124757-6e7f6cde8bf2 to v0.8.2-0.20251025182631-51a03e0f7864.
E2E test refinements
test/e2e/e2e_test.go		 In TestSweepBatchOutput the initial ListVtxos call ignores spent results and asserts on spendable-only counts and fields; after fund recovery the test captures both spendable and spent lists and asserts the recovered VTXO is marked spent with correct Txid, Swept, and Spent flags.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Pay attention to the upgraded go-sdk major/minor change (v0.7.x -> v0.8.2) for any behavioral changes that might affect tests.
  • Review the e2e test assertions around VTXO fields and any mocks or fixtures they rely on.

Possibly related PRs

Suggested reviewers

  • Kukks

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "bump sdk to latest + fix e2e" directly corresponds to the main changes in the changeset: dependency version updates in go.mod and pkg/ark-cli/go.mod (specifically upgrading go-sdk from v0.7.2 to v0.8.2 along with ark-lib), and fixes to the e2e test logic in test/e2e/e2e_test.go. The title is concise, clear, and captures both significant aspects of the change without unnecessary verbosity. A teammate reviewing the history would immediately understand that this PR contains dependency updates and e2e test fixes.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0027188 and cb77cb5.

⛔ Files ignored due to path filters (2)
  • go.sum is excluded by !**/*.sum
  • pkg/ark-cli/go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • go.mod (1 hunks)
  • pkg/ark-cli/go.mod (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • pkg/ark-cli/go.mod
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: unit tests
  • GitHub Check: Build and Scan
  • GitHub Check: integration tests
🔇 Additional comments (1)
go.mod (1)

24-24: Go-sdk v0.8.2 updates are properly integrated with test coverage confirmed.

Verification results:

  1. ✓ Dependency sync: go-sdk v0.8.2-0.20251025182631-51a03e0f7864 consistent across root and pkg/ark-cli/go.mod
  2. ✓ Code changes integrated: internal/interface/grpc/handlers/indexer.go implements new VTXO filter parameters (spendableOnly, spentOnly, recoverableOnly) with proper mutually-exclusive validation
  3. ✓ E2E test coverage: test/e2e/e2e_test.go explicitly uses opt.WithSpentOnly(), confirming new filters are tested; multiple e2e test files exercise VTXO logic
  4. ✓ No unresolved issues: No TODOs/FIXMEs found; ark-lib version bump is low-risk (pseudo-version within same v0.7.2 release)

Note: v0.8.2 is a pseudo-version (development build, Oct 25, 2025), not yet an official release; v0.8.1 (Oct 23) is the latest released tag.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@altafan altafan merged commit 144d6a4 into arkade-os:master Oct 28, 2025
5 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Oct 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@altafan altafan altafan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@louisinger @altafan