api-spec/openapi/swagger/ark/v1/service.swagger.json (1)

648-651: Fix minor doc typo (“the the proof of funds”)

Remove the duplicated “the”.

Since this file is generated, fix the comment in the .proto and regenerate.

client/rest/client.go (1)

139-145: Switch to V1IntentProof is correct; add basic input validation.

Before sending the request, fail fast on empty proof/message to surface clearer client-side errors.

Apply diffs:

 func (a *restClient) RegisterIntent(
   ctx context.Context,
   proof, message string,
 ) (string, error) {
+  if proof == "" || message == "" {
+    return "", fmt.Errorf("proof and message are required")
+  }
   body := &models.V1RegisterIntentRequest{
     Intent: &models.V1IntentProof{
       Message: message,
       Proof:   proof,
     },
   }

-func (a *restClient) DeleteIntent(_ context.Context, proof, message string) error {
+func (a *restClient) DeleteIntent(_ context.Context, proof, message string) error {
+  if proof == "" || message == "" {
+    return fmt.Errorf("proof and message are required")
+  }
   body := &models.V1DeleteIntentRequest{
     Proof: &models.V1IntentProof{
       Message: message,
       Proof:   proof,
     },
   }

Also applies to: 157-162

client/rest/service/models/v1_intent_proof.go (1)

15-25: If message/proof are required, enforce via OpenAPI (don’t hand-edit generated code).

The generated type has no validations. If both fields are mandatory, mark them as required in the OpenAPI schema (and optionally add formats/patterns), then re-generate to get Validate/ContextValidate checks. This prevents accidental empty payloads early in clients.

Also applies to: 27-35

client/grpc/client.go (1)

150-156: Good migration to arkv1.IntentProof; add argument checks for clearer errors.

Validate inputs before RPC to return InvalidArgument instead of server-side failures.

Apply diffs:

 func (a *grpcClient) RegisterIntent(
   ctx context.Context,
   proof, message string,
 ) (string, error) {
+  if proof == "" || message == "" {
+    return "", status.Error(codes.InvalidArgument, "proof and message are required")
+  }
   req := &arkv1.RegisterIntentRequest{
     Intent: &arkv1.IntentProof{
       Message: message,
       Proof:   proof,
     },
   }

-func (a *grpcClient) DeleteIntent(ctx context.Context, proof, message string) error {
+func (a *grpcClient) DeleteIntent(ctx context.Context, proof, message string) error {
+  if proof == "" || message == "" {
+    return status.Error(codes.InvalidArgument, "proof and message are required")
+  }
   req := &arkv1.DeleteIntentRequest{
     Proof: &arkv1.IntentProof{
       Message: message,
       Proof:   proof,
     },
   }

Also applies to: 166-171

utils.go (4)

315-323: Return-shape clarity: document parallelism or introduce a small struct.

toIntentInputs returns inputs, exitLeaves, and arkFields as three parallel slices. Either document the 1:1 index relationship prominently here or return a slice of a small struct bundling these per-input fields to avoid accidental misalignment down the line.

---

394-399: Remove dead code around nextInputIndex.

nextInputIndex is computed and mutated but never used, which is confusing and risks future misuse.

Apply this diff:

-  nextInputIndex := len(inputs)
-  if nextInputIndex > 0 {
-    // if there is non-notes inputs, count the extra intent proof input
-    nextInputIndex++
-  }
@@
-    nextInputIndex++
-    // if the note vtxo is the first input, it will be used twice
-    if nextInputIndex == 1 {
-      nextInputIndex++
-    }

Also applies to: 438-443

---

406-419: Minor readability: avoid name collision with inputs; use a distinct identifier.

Rename the inner variable input to noteInput for clarity.

Apply this diff:

-  outpoint, input, err := parsedNote.IntentProofInput()
+  outpoint, noteInput, err := parsedNote.IntentProofInput()
@@
-  inputs = append(inputs, intent.Input{
+  inputs = append(inputs, intent.Input{
     OutPoint: outpoint,
     Sequence: wire.MaxTxInSequenceNum,
     WitnessUtxo: &wire.TxOut{
-      Value:    input.WitnessUtxo.Value,
-      PkScript: input.WitnessUtxo.PkScript,
+      Value:    noteInput.WitnessUtxo.Value,
+      PkScript: noteInput.WitnessUtxo.PkScript,
     },
   })
@@
-  arkFields = append(arkFields, input.Unknowns)
+  arkFields = append(arkFields, noteInput.Unknowns)

---

515-551: Rename unused inputs parameter to blank identifier
This removes the unused-parameter warning without touching call sites:

-func registerIntentMessage(
-    inputs []intent.Input, outputs []types.Receiver,
+func registerIntentMessage(
+    _ []intent.Input, outputs []types.Receiver,
     cosignersPublicKeys []string,
) (string, []*wire.TxOut, error) {

client.go (6)

1852-1864: Plumb context and delegate to makeIntent(ctx, ...).

Use the caller’s ctx for signing/cancellation and forward it to makeIntent.

-func (a *arkClient) makeRegisterIntent(
-	inputs []intent.Input, leafProofs []*arklib.TaprootMerkleProof,
-	outputs []types.Receiver, cosignersPublicKeys []string, arkFields [][]*psbt.Unknown,
-) (string, string, error) {
+func (a *arkClient) makeRegisterIntent(
+	ctx context.Context,
+	inputs []intent.Input,
+	leafProofs []*arklib.TaprootMerkleProof,
+	outputs []types.Receiver,
+	cosignersPublicKeys []string,
+	arkFields [][]*psbt.Unknown,
+) (string, string, error) {
   message, outputsTxOut, err := registerIntentMessage(
     inputs, outputs, cosignersPublicKeys,
   )
   if err != nil {
     return "", "", err
   }
-  return a.makeIntent(message, inputs, outputsTxOut, leafProofs, arkFields)
+  return a.makeIntent(ctx, message, inputs, outputsTxOut, leafProofs, arkFields)
 }

---

1866-1880: Make Delete TTL configurable and accept ctx.

Hardcoding 2 minutes may cause avoidable retries under load. Consider a default with override (option/env). Also pass ctx through.

-func (a *arkClient) makeDeleteIntent(
-	inputs []intent.Input, leafProofs []*arklib.TaprootMerkleProof, arkFields [][]*psbt.Unknown,
-) (string, string, error) {
+func (a *arkClient) makeDeleteIntent(
+	ctx context.Context,
+	inputs []intent.Input,
+	leafProofs []*arklib.TaprootMerkleProof,
+	arkFields [][]*psbt.Unknown,
+) (string, string, error) {
   message, err := intent.DeleteMessage{
     BaseMessage: intent.BaseMessage{
       Type: intent.IntentMessageTypeDelete,
     },
     ExpireAt: time.Now().Add(2 * time.Minute).Unix(),
   }.Encode()
   if err != nil {
     return "", "", err
   }
-  return a.makeIntent(message, inputs, nil, leafProofs, arkFields)
+  return a.makeIntent(ctx, message, inputs, nil, leafProofs, arkFields)
 }

---

942-949: Pass ctx into makeRegisterIntent after refactor.

-  proofTx, message, err := a.makeRegisterIntent(
-    inputs, exitLeaves, outputs, cosignersPublicKeys, arkFields,
-  )
+  proofTx, message, err := a.makeRegisterIntent(
+    ctx, inputs, exitLeaves, outputs, cosignersPublicKeys, arkFields,
+  )

---

967-973: Pass ctx into makeDeleteIntent after refactor.

-  proofTx, message, err := a.makeDeleteIntent(inputs, exitLeaves, arkFields)
+  proofTx, message, err := a.makeDeleteIntent(ctx, inputs, exitLeaves, arkFields)

---

2044-2047: Prefer ctx over Background for signer session creation.

Plumb ctx to handleOptions to allow cancellation/timeouts in wallet.NewVtxoTreeSigner.

-  signerSessions, signerPubKeys, err := a.handleOptions(options, inputs, notes)
+  signerSessions, signerPubKeys, err := a.handleOptions(ctx, options, inputs, notes)

---

2741-2775: handleOptions: accept ctx and avoid context.Background().

Use the caller’s ctx to bound wallet signer operations.

-func (a *arkClient) handleOptions(
-  options SettleOptions, inputs []intent.Input, notesInputs []string,
-) ([]tree.SignerSession, []string, error) {
+func (a *arkClient) handleOptions(
+  ctx context.Context,
+  options SettleOptions,
+  inputs []intent.Input,
+  notesInputs []string,
+) ([]tree.SignerSession, []string, error) {
@@
-    signerSession, err := a.wallet.NewVtxoTreeSigner(
-      context.Background(),
-      inputsToDerivationPath(outpoints, notesInputs),
-    )
+    signerSession, err := a.wallet.NewVtxoTreeSigner(
+      ctx,
+      inputsToDerivationPath(outpoints, notesInputs),
+    )

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

api-spec/openapi/swagger/ark/v1/service.swagger.json (2)

601-611: Make proof and message required; document encoding.

The v1Intent schema allows empty payloads because neither proof nor message is marked as required, and encoding guidance is missing. Without this, SDKs will not enforce presence or correct encoding at validation time.

As noted in the past review, update the source .proto to mark both fields as required (e.g., (google.api.field_behavior) = REQUIRED) and add clear encoding metadata in field descriptions (e.g., proof = base64, message = UTF-8/JSON), then regenerate the OpenAPI spec.

---

477-479: Require intent field in v1DeleteIntentRequest.

The intent field is optional in the schema, but DeleteIntent cannot proceed without proof. Mark it as required in the source proto and regenerate.

As noted in the past review, add "intent" to the required array in the v1DeleteIntentRequest definition in the source proto (e.g., (google.api.field_behavior) = REQUIRED) and regenerate the OpenAPI spec.

client/rest/service/models/v1_register_intent_request.go (1)

21-23: Require intent field in generated model.

The Intent field is optional (omitempty), but the API requires it. Mark it as required in the source proto and regenerate to remove omitempty and enforce validation.

As noted in the past review, update the source proto to mark intent as required (e.g., (google.api.field_behavior) = REQUIRED) and regenerate the SDK so the Go model enforces the field at validation time.

client/rest/service/models/v1_delete_intent_request.go (1)

21-23: Require intent field in generated model.

The Intent field is optional (omitempty), but DeleteIntent cannot proceed without proof. Mark it as required in the source proto and regenerate to enforce validation.

As noted in the past review, update the source proto to mark intent as required (e.g., (google.api.field_behavior) = REQUIRED) and regenerate the SDK so the Go model removes omitempty and enforces the field at validation time.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro