ipv6 loopback sets insecure, opus improvements#3768
Merged
Conversation
* config.c — Redis config: add upper bound (10MB) on response length + malloc failure check * db.c — Fix uint16_t → int for path length comparison; check statvfs() return value and handle f_blocks == 0 to avoid divide-by-zero * parsers/quic.c — Prevent buffer overflow: clamp memcpy length to sizeof(buffer) * reader-scheme.c — Prevent undefined behavior: clamp pcapng timestamp resolution bit shift to max 63 * thirdparty/patricia.c/.h — Remove unused prefix_toa/prefix_toa2/prefix_toa2x functions (dead code with thread-safety issues) * arkimeCache.js — Fix require path ../common/arkimeUtil → ./arkimeUtil * arkimeConfig.js — Fix JSON.stringify replacer false → null; add IPv6 [::1] to isInsecure() * arkimeUtil.js — Fix expressErrorHandler: add headersSent guard, remove erroneous next() after res.send() * auth.js — Add MD5/RFC 2617 documentation nosemgrep annotation on pass2ha1() * notifier.js — Add missing .catch() on searchNotifiers promise chain * user.js — Use rolesQ copy instead of this.roles in expandFromRoles loop * api-buildquery.t — Add 3 test cases for :: (all-zeros IPv6) IP search expressions Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.