more security hardening#3792
Merged
Merged
Conversation
capture: - reader-scheme.c: Fix possible heap overflow in NG_INTERFACE state where blockSize was double-decremented during partial reads - tls.c/dtls.c: Fix JA4 counter wraparound — widen counters from uint8_t to uint16_t and add ARRAY_LEN bounds checks on array writes viewer: - apiHunts.js: Require S2S auth for remoteHunt endpoint; replace query_string with multi_match to prevent ES query injection via searchTerm - apiSessions.js: encodeURIComponent on tags in sendSessionsList URL - viewer.js: Validate x-arkime-auth cryptographically for receiveSession; add packetSearch permission to remoteHunt route - internals.js: Default uploadFileSizeLimit to 2GB common: - user.js: Allowlist sortUsers fields to prevent sorting by password hash wiseService: - source.splunk.js: Escape SPL metacharacters in search term - source.threatstream.js: Replace exec() with execFile() to prevent shell injection Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- viewer/apiHistory.js — query_string → multi_match + deleteHistory index validation - cont3xt/db.js — query_string → multi_match + sortBy/sortOrder allowlist - cont3xt/integration.js — JSON.parse try-catch with logging - cont3xt/linkGroup.js — URL scheme validation (http/https only) - capture/parsers/http2.c — negative inlen guard in PUSH_PROMISE
- viewer/apiHunts.js — multi_match → wildcard on ['name', 'userId'] - viewer/apiHistory.js — multi_match → wildcard on ['expression', 'userId', 'api', 'view.name', 'view.expression'] - cont3xt/db.js — multi_match → wildcard on ['indicator', 'iType', 'tags']
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
capture:
viewer:
common:
wiseService:
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.