Capture parser hardening and ASN.1 OID fix#3914
Merged
Merged
Conversation
- parsers.c: fix ASN.1 OID first-arc decoding per X.690 (e.g. LLDP OIDs now show as 1.0.8802... not 40.8802...) - bgp: validate length field, unregister on bad - diameter: check BSB error after AVP padding skip - dnp3 udp: verify computed total frame length fits datagram - ldap: handle arkime_parser_buf_add truncation - m2ua/m3ua: validate msgLen and limit param BSB - pana: validate msgLen and limit AVP BSB - postgresql: classifier decodes full 4-byte plen - ptp: validate messageLength in classifier and parser - radius: classifier requires len >= 20 - socks5: drop artificial len <= 5 cap on greeting - synchrophasor: unregister tcp on oversize frame; validate udp frameSize - tftp: require both filename and mode NULs per RFC 1350 - pcap-over-IP: free client on unknown magic, fix %xs format typo - reader-scheme: validate pcapng EPB block size, require olen >= 1 for if_tsresol - daq: pass non-NULL user pointer to thread queue - lua/session: use int/lua_tointeger for offset - writer-s3: bump partNumbers[] to 10001, clamp completion loop - tests: update SNMPv2c expected OIDs; extend PTP Announce in arkime_synthetic to satisfy msgLen Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.