Add arkime_session_rm_protocol; drop ftp on confirmed SMTP#3919
Merged
Conversation
The 220 banner is shared by FTP and SMTP, so misc.c's other220 classifier may tag a session as ftp before SMTP commands are seen. Once the smtp parser observes a HELO/EHLO command we know for sure the session is SMTP and the ftp tag is spurious. - Add arkime_session_rm_protocol() helper for removing a protocol from a session's STR_HASH protocol field - smtp parser removes the ftp protocol tag when it sees HELO/EHLO - Regenerate wireshark-bdat golden which had spurious ftp tag Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 220 banner is shared by FTP and SMTP, so misc.c's other220 classifier may tag a session as ftp before SMTP commands are seen. Once the smtp parser observes a HELO/EHLO command we know for sure the session is SMTP and the ftp tag is spurious.
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.