Skip byte-based UDP classifiers on UDP/53 to avoid DNS false-matches#3932
Merged
Conversation
…3932) - parsers.c: in arkime_parsers_classify_udp, skip the byte-based classifier dispatch (Udp0/Udp1/Udp2) when either side of the session is on UDP/53. Port-based classifiers still run, so dns.c is unaffected. Parsers that legitimately need to run on UDP/53 should register a port-based classifier. - arkime.h: mark ARKIME_RETURN_IF_DNS_PORT as deprecated; keep the macro for out-of-tree parser compatibility. - Remove now-redundant ARKIME_RETURN_IF_DNS_PORT calls from in-tree parsers (bacnet, dnp3, gtp, misc, pana, rdp, synchrophasor). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.