Fix UAF in command-socket --notify#3988
Merged
Merged
Conversation
- Defer file-done notification to packet thread's FILE_DONE sentinel so the notification fires when packets have actually drained, not when the file has just been queued. - Stop eagerly dereferencing the scheme actions slot while packets (and their sessions referencing actions->ops) are still in flight. - Track load_thread recursion depth so the actions-held client ref is released exactly once at the outermost call, allowing the command-socket client to close after exit. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Older GCC doesn't see through BSB_LIMPORT writes; initialize major, minor, build to 0 to silence -Wmaybe-uninitialized. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use pointer-swap with atomic store/load so packet threads never read a bpf_program that the scheme thread is mutating in place. Add ARKIME_THREAD_ATOMIC_STORE/LOAD helper macros. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.