Skip to content

Fixed error handling if download fails #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arin-pang merged 2 commits into from
Feb 9, 2020
Merged

Fixed error handling if download fails #3

arin-pang merged 2 commits into from
Feb 9, 2020

Conversation

@Eddman
Copy link
Contributor

@Eddman Eddman commented Feb 6, 2020

getTags(1) is called outside of async function so try-catch does not catch errors. We have to use Promise.catch instead.

@arin-pang arin-pang merged commit c4adf76 into arin-pang:master Feb 9, 2020
@arin-pang
Copy link
Owner

arin-pang commented Feb 9, 2020

Oh, Thanks @Eddman. it's my mistake. I will make a new release soon.

@Eddman Eddman deleted the patch-1 branch February 10, 2020 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Eddman @arin-pang