Skip to content

add monitor/schema action #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ronenlu wants to merge 13 commits into from
Closed

add monitor/schema action #256

ronenlu wants to merge 13 commits into from

Conversation

@ronenlu
Copy link
Member

@ronenlu ronenlu commented Nov 7, 2024 •
edited
Loading

example run:

image

@github-actions
Copy link

github-actions bot commented Nov 7, 2024

Atlas Lint Report

Analyzed migrations

StatusStepResultDiagnostics
Detect New Migration FilesFound 0 new migration files (from 0 total)
Replay Migration FilesLoaded 0 changes on dev database
Connect your project to Atlas Cloud to get more safety checks
Migrations automatically reviewed by Atlas

@github-actions
Copy link

github-actions bot commented Nov 7, 2024

Atlas Lint Report

Analyzed migrations2

StatusStepResultDiagnostics
Detect New Migration FilesFound 0 new migration files (from 0 total)
Replay Migration FilesLoaded 0 changes on dev database
Connect your project to Atlas Cloud to get more safety checks
Migrations automatically reviewed by Atlas

@github-actions
Copy link

github-actions bot commented Nov 7, 2024 •
edited
Loading

atlas migrate lint on atlasaction/testdata/migrations_destructive

Status Step Result
1 new migration file detected 20230925192914.sql
ERD and visual diff generated View Visualization
Analyze 20230925192914.sql
1 reports were found in analysis		 Destructive changes detected
Dropping table "t1" (DS102)
Read the full linting report on Atlas Cloud

@github-actions
Copy link

github-actions bot commented Nov 7, 2024 •
edited
Loading

Atlas detected changes to the desired schema

Migration Plan (View on Atlas Cloud)

-- Create "t1" table
CREATE TABLE `t1` (
  `c1` integer NOT NULL
);
-- Create "t2" table
CREATE TABLE `t2` (
  `c1` integer NOT NULL
);
-- Create "t3" table
CREATE TABLE `t3` (
  `c1` integer NOT NULL,
  `c2` integer NOT NULL
);

Atlas lint results

Status Step Result
Detect schema changes3 new statements detected
No issues found
📝 Steps to edit this migration plan

1. Run the following command to pull the generated plan to your local workstation:

atlas schema plan pull --url "atlas://atlas-action/plans/pr-256-R1cGcSfo" > pr-256-R1cGcSfo.plan.hcl

2. Open pr-256-R1cGcSfo in your editor and modify it as needed. Note that the result of the plan should align
the database with the desired state. Otherwise, Atlas will report a schema drift.

3. Push the updated plan to the registry using the following command:

atlas schema plan push --pending --env test --file pr-256-R1cGcSfo.plan.hcl

4. Re-trigger the schema/plan action to update this comment:

gh run rerun 11910339752

@ronenlu ronenlu force-pushed the agent_action branch 13 times, most recently from 0f699b8 to 19725f6 Compare November 7, 2024 13:16
@ronenlu ronenlu force-pushed the agent_action branch 2 times, most recently from 98f4b37 to ea49db6 Compare November 7, 2024 14:27
noamcattan
noamcattan reviewed Nov 7, 2024
View reviewed changes
@ronenlu ronenlu requested a review from rotemtam November 7, 2024 14:40
masseelch
masseelch reviewed Nov 8, 2024
View reviewed changes
noamcattan
noamcattan reviewed Nov 18, 2024
View reviewed changes
masseelch
masseelch reviewed Nov 19, 2024
View reviewed changes
masseelch
masseelch reviewed Nov 19, 2024
View reviewed changes
masseelch
masseelch reviewed Nov 19, 2024
View reviewed changes
@ronenlu ronenlu changed the title add running agent action add monitor/schema action Nov 19, 2024
masseelch
masseelch reviewed Nov 19, 2024
View reviewed changes
Copy link
Member

@masseelch masseelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@a8m @rotemtam I'll let one of you approve.

a8m
a8m reviewed Nov 19, 2024
View reviewed changes
monitor/schema/action.yml
@@ -0,0 +1,36 @@
name: 'Atlas Schema Monitor'
Copy link
Member

@a8m a8m Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: 'Atlas Schema Monitor'
name: 'Atlas Schema Monitoring'

@ronenlu ronenlu closed this Nov 20, 2024
@ronenlu ronenlu deleted the agent_action branch March 2, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a8m a8m a8m left review comments

@masseelch masseelch masseelch left review comments

@rotemtam rotemtam Awaiting requested review from rotemtam

@noamcattan noamcattan Awaiting requested review from noamcattan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ronenlu @a8m @masseelch @noamcattan