Skip to content

atlas-action: add collect stats input to manifests #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
masseelch merged 4 commits into from
Dec 18, 2025
Merged

atlas-action: add collect stats input to manifests #444

masseelch merged 4 commits into from
Dec 18, 2025

Conversation

@masseelch
Copy link
Member

@masseelch masseelch commented Dec 18, 2025

No description provided.

@masseelch masseelch requested a review from noamcattan December 18, 2025 09:15
@github-actions
Copy link

github-actions bot commented Dec 18, 2025 •
edited
Loading

atlas migrate lint on atlasaction/testdata/migrations_destructive

Status Step Result
1 new migration file detected 20230925192914.sql
ERD and visual diff generated View Visualization
Analyze 20230925192914.sql
1 reports were found in analysis		 Destructive changes detected
Dropping table "t1" (DS102)
Read the full linting report on Atlas Cloud

@github-actions
Copy link

github-actions bot commented Dec 18, 2025 •
edited
Loading

Atlas detected changes to the desired schema

Migration Plan for atlas-action • View on Atlas Cloud

-- Create "t1" table
CREATE TABLE `t1` (
  `c1` integer NOT NULL
);
-- Create "t2" table
CREATE TABLE `t2` (
  `c1` integer NOT NULL
);
-- Create "t3" table
CREATE TABLE `t3` (
  `c1` integer NOT NULL,
  `c2` integer NOT NULL
);

Atlas lint results

Status Step Result
Detect schema changes3 new statements detected
No issues found
📝 Steps to edit this migration plan

1. Run the following command to pull the generated plan to your local workstation:

atlas schema plan pull --url "atlas://atlas-action/plans/pr-443-R1cGcSfo" > pr-443-R1cGcSfo.plan.hcl

2. Open pr-443-R1cGcSfo in your editor and modify it as needed. Note that the result of the plan should align
the database with the desired state. Otherwise, Atlas will report a schema drift.

3. Push the updated plan to the registry using the following command:

atlas schema plan push --pending --file pr-443-R1cGcSfo.plan.hcl

4. Re-trigger the schema/plan action to update this comment:

gh run rerun 20332223407

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

atlas schema lint on file://schema.lt.hcl

Status Rule Result
Naming violations detected Table "t1" violates the naming policy (NM102) schema.lt.hcl:1:1
Table "t2" violates the naming policy (NM102) schema.lt.hcl:1:1
Primary-key-required rule violated All tables must have a primary key
Table t1 must have a primary key schema.lt.hcl:3:1
Table t2 must have a primary key schema.lt.hcl:10:1
Primary-key-required rule violated All tables must have a primary key
Table t1 must have a primary key schema.lt.hcl:3:1
Table t2 must have a primary key schema.lt.hcl:10:1

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

atlas schema lint on sqlite://schemarule.db

Status Rule Result
Naming violations detected Table "main.T1" violates the naming policy (NM102)
Primary-key-required rule violated All tables must have a primary key
Table T1 must have a primary key
Primary-key-required rule violated All tables must have a primary key
Table T1 must have a primary key

@noamcattan
Copy link
Member

noamcattan commented Dec 18, 2025

Update the readme also?

@noamcattan
Copy link
Member

noamcattan commented Dec 18, 2025

I also added the "include" input, you can add it as well

@masseelch masseelch requested review from giautm and ronenlu December 18, 2025 09:31
ronenlu
ronenlu reviewed Dec 18, 2025
View reviewed changes
@noamcattan
Copy link
Member

noamcattan commented Dec 18, 2025

cc @giautm for the azure part

@masseelch masseelch merged commit 5cd626a into master Dec 18, 2025
27 checks passed
@masseelch masseelch deleted the j/manifest branch December 18, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronenlu ronenlu ronenlu left review comments

@giautm giautm giautm approved these changes

@noamcattan noamcattan Awaiting requested review from noamcattan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@masseelch @noamcattan @giautm @ronenlu