fix(anta.tests): Added fix for issue: VerifyCPUUtilization failing when added in the middle of other tests #1294
Conversation
CodSpeed Performance ReportMerging #1294 will not alter performanceComparing Summary
|
| self.result.is_failure(f"Device has reported agent crashes:\n * {agents}") | ||
|
|
||
|
|
||
| class VerifyCPUUtilization(AntaTest): |
There was a problem hiding this comment.
Can we have separate test (i.e VerifyRunningProcesses) where we can verify the average runnable or uninterruptible processes.
So we can have two separate tests
- The existing VerifyCPUUtilization test focus only on CPU usage (with a deprecation warning to the new test).
- A new test, VerifyRunningProcesses, to handle the process
@carl-baillargeon could you please confirm?
There was a problem hiding this comment.
IMO the current test VerifyCPUUtilization is broken and leads to false positives so it's fine to modify its behavior so it's more robust.
…en added in the middle of other tests
975c8c4 to
24823b9
Compare
|
carl-baillargeon
left a comment
There was a problem hiding this comment.
Let's investigate more about the proper default values for the averages. It depends on the CPU count on EOS. Maybe fetch the CPU count first using lscpu or something and then check the averages.
Description
Added fix for issue: VerifyCPUUtilization failing when added in the middle of other tests
Fixes #1283
Checklist:
pre-commit run)tox -e testenv)