Modernize Go features: Use slices and strings.Builder#5
Conversation
- Replaced `sort.Interface` implementation on `ParamArray` with `slices.SortFunc`. - Replaced `append` idiom for cloning slices with `slices.Clone`. - Replaced byte slice append in `Escape` with `strings.Builder`. - Simplified conditional logic in `SignSha1Hmac1`. - Removed `sort` package import and added `slices` package import. - This requires Go 1.21 or later. Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Upgrade the codebase to use modern Go features (Go 1.21+). Specifically, this introduces the
slicespackage for sorting and cloning, andstrings.Builderfor efficient string concatenation in theEscapefunction. It also removes the boilerplate implementation ofsort.InterfaceforParamArray.PR created automatically by Jules for task 16531313441885284781 started by @arran4