Skip to content

Add OIDC 'unauthorized' failure message#1911

Merged
sbreker merged 1 commit into
qa/2.xfrom
dev/oidc-config-error-handling
Jan 28, 2025
Merged

Add OIDC 'unauthorized' failure message#1911
sbreker merged 1 commit into
qa/2.xfrom
dev/oidc-config-error-handling

Conversation

@sbreker

@sbreker sbreker commented Jan 24, 2025

Copy link
Copy Markdown
Member

If an error occurs in AtoM after successful authentication with the OIDC endpoint, end the AtoM session and redirect to the standard AtoM 'Unauthorized' message template.

Previously, errors that occurred in AtoM after successful authentication with the OIDC endpoint would fail silently redirecting the user to the AtoM home page in an unauthenticated state.

@sbreker sbreker force-pushed the dev/oidc-config-error-handling branch from a3d7628 to a6a090a Compare January 24, 2025 22:55
@sbreker sbreker requested a review from a team January 25, 2025 00:00
@sbreker sbreker force-pushed the dev/oidc-config-error-handling branch from a6a090a to 1448a80 Compare January 25, 2025 01:38
@sbreker sbreker changed the title Update OIDC logout flow Add OIDC 'unauthorized' failure message Jan 25, 2025

@anvit anvit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @sbreker

@anvit anvit added the Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. label Jan 27, 2025
@anvit anvit added this to the 2.9.0 milestone Jan 27, 2025
If an error occurs in AtoM after successful authentication with the OIDC
endpoint, end the AtoM session and redirect to the standard AtoM
'Unauthorized' message template.

Previously, errors that occurred in AtoM after successful authentication
with the OIDC endpoint would fail silently redirecting the user to the
AtoM home page in an unauthenticated state.
@sbreker sbreker force-pushed the dev/oidc-config-error-handling branch from 1448a80 to 1206a73 Compare January 28, 2025 22:02
@sbreker sbreker merged commit 1206a73 into qa/2.x Jan 28, 2025
@sbreker sbreker deleted the dev/oidc-config-error-handling branch December 8, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants