Skip to content

Add switch for calling Te solver #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
ccollins22 wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Add switch for calling Te solver #96

ccollins22 wants to merge 1 commit into from

Conversation

@ccollins22
Copy link
Member

@ccollins22 ccollins22 commented Jul 25, 2024

When heating and cooling rates are too noisy to calculate reliable Te (e.g. only a few species are NLTE) add option to set Te=TJ instead

@ccollins22 ccollins22 requested a review from lukeshingles as a code owner July 25, 2024 09:37
@ccollins22 ccollins22 marked this pull request as draft July 25, 2024 09:37
@lukeshingles
Copy link
Member

lukeshingles commented Jul 26, 2024

I didn't understand the physics justification, but on the software side, is it worth the maintenance burden of an extra configuration option versus four lines of local changes? Are you going to publish models with this mode?

@lukeshingles lukeshingles force-pushed the develop branch 3 times, most recently from a434b42 to ec46b73 Compare September 4, 2024 15:00
@lukeshingles lukeshingles force-pushed the develop branch 7 times, most recently from 9ef9733 to 8111c67 Compare February 19, 2025 14:48
@lukeshingles lukeshingles force-pushed the develop branch 6 times, most recently from 238a966 to 62c04e6 Compare March 14, 2025 15:53
@lukeshingles lukeshingles force-pushed the develop branch 2 times, most recently from 0f6bcf4 to bc467fd Compare July 15, 2025 14:03
@lukeshingles lukeshingles force-pushed the develop branch 2 times, most recently from ea2cf92 to c2fc15f Compare August 26, 2025 10:11
@lukeshingles lukeshingles force-pushed the develop branch 7 times, most recently from 2781e4b to d8f50ec Compare August 26, 2025 13:04
@lukeshingles lukeshingles force-pushed the develop branch 3 times, most recently from 095a45f to 7da884b Compare September 11, 2025 10:33
@lukeshingles lukeshingles force-pushed the develop branch 3 times, most recently from fefa384 to 0b6e44f Compare October 1, 2025 10:24
@lukeshingles lukeshingles force-pushed the develop branch 2 times, most recently from f10b3ac to 8fecd57 Compare October 13, 2025 15:03
@lukeshingles lukeshingles force-pushed the develop branch 3 times, most recently from 1386401 to 9c1b024 Compare October 28, 2025 13:18
@lukeshingles lukeshingles force-pushed the develop branch 3 times, most recently from 2873d47 to d1b5cb9 Compare October 31, 2025 12:37
@lukeshingles lukeshingles force-pushed the develop branch 3 times, most recently from 9d04064 to 5ab61a7 Compare December 17, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukeshingles lukeshingles Awaiting requested review from lukeshingles lukeshingles is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ccollins22 @lukeshingles