Change default CSS to support RTL languages #4740
Open
+190
−176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace physical CSS (left/right) properties with logical (inline-start/inline-end etc) to support RTL languages.
See https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_logical_properties_and_values for an explanation of these properties.
With this CSS there's no change for an English page, but an Arabic or Hebrew page only needs
<html dir="rtl">for the page to flow as expected, TOC shown on the right, admonition icons are on the right, etc.I haven't added any language-specific adjustments, like the numerals used for ordered lists, since that would also vary for LTR languages (
list-style-type: georganorthaifor example).For issue #1601