Allow installing extensions by dropping them into the preferences dialog#5697
Merged
Merged
Conversation
aseprite-bot
reviewed
Mar 7, 2026
aseprite-bot
left a comment
Collaborator
There was a problem hiding this comment.
clang-tidy made some suggestions
| miniFontPreview()->setFont(m_miniFont); | ||
| } | ||
|
|
||
| bool onProcessMessage(Message* msg) override |
Collaborator
There was a problem hiding this comment.
warning: method 'onProcessMessage' can be made static [readability-convert-member-functions-to-static]
Suggested change
| bool onProcessMessage(Message* msg) override | |
| static bool onProcessMessage(Message* msg) override |
| { | ||
| switch (msg->type()) { | ||
| case kDropFilesMessage: | ||
| base::paths files = static_cast<DropFilesMessage*>(msg)->files(); |
Collaborator
There was a problem hiding this comment.
warning: variable 'files' of type 'base::paths' (aka 'vector<basic_string>') can be declared 'const' [misc-const-correctness]
Suggested change
| base::paths files = static_cast<DropFilesMessage*>(msg)->files(); | |
| base::paths const files = static_cast<DropFilesMessage*>(msg)->files(); |
Member
|
LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now if you double click an extension from the OS, install it, and then attempt to install another one, it does nothing because "dropping" files only works when the foreground window is the main window.
This change allows the event to propagate so we can have modal dialogs that accept file drops, in this case the Preferences dialog accepts
.aseprite-extensionand.zip(since if you're dropping something onto here, it'll most likely be an extension).