Skip to content

False positive S113 for httpx.AsyncClient #12240

Closed as not planned
Closed as not planned
False positive S113 for httpx.AsyncClient#12240

Description

@dybi
dybi
opened on Jul 8, 2024

S113 is reported by ruff for httpx.AsyncClient() (https://docs.astral.sh/ruff/rules/request-without-timeout/)
whereas httpx works differntly than requests in this area and there is a finite default: https://github.com/encode/httpx/blob/db9072f998b53ff66d50778bf5edee8e2cc8ede1/httpx/_client.py#L1390

Minimal app do reproduce:

import httpx

client = httpx.AsyncClient()

ruff version = 0.5.1.

Activity

  1. MichaReiser commented on Jul 8, 2024

    @MichaReiser
    MichaReiser
    on Jul 8, 2024
    Member

    Yes sorry, that was an oversight on our end and thanks for reporting! I think this is already fixed and will go out in our next release #12213

  2. MichaReiser
    closed this as not plannedon Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions