fix(composer): refetch nonce on submission failure #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mposer-nonce-refetch
SuperFluffy
reviewed
Oct 10, 2023
noot
reviewed
Oct 11, 2023
noot
reviewed
Oct 11, 2023
noot
reviewed
Oct 11, 2023
noot
reviewed
Oct 11, 2023
a784932 to
20c173e
Compare
SuperFluffy
reviewed
Oct 20, 2023
Contributor
|
I pushed a change replacing the ping-pong in the All of this was also necessary because expressing retries (using |
noot
reviewed
Oct 25, 2023
noot
reviewed
Oct 25, 2023
noot
reviewed
Oct 25, 2023
noot
reviewed
Oct 25, 2023
noot
reviewed
Oct 25, 2023
noot
reviewed
Oct 25, 2023
noot
reviewed
Oct 25, 2023
noot
reviewed
Oct 25, 2023
noot
reviewed
Oct 25, 2023
noot
approved these changes
Oct 25, 2023
Contributor
noot
left a comment
There was a problem hiding this comment.
just a few comments to address before merge!
noot
reviewed
Oct 25, 2023
Contributor
|
Addressed all comments. Waiting for the @itamarreif as the original author to give the ok to merge this. The PR text should be updated before merge. |
SuperFluffy
approved these changes
Oct 26, 2023
itamarreif
commented
Oct 26, 2023
…mposer-nonce-refetch
…h' into itamarreif/composer-nonce-refetch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds handling for sequencer responses to transaction submission. Failures caused by invalid nonce reset the stored nonce and resubmit the transaction.
Background
See #293 and #307
Changes
SubmitFutfutureSubmitFutis a state machine that manages bundle submission, nonce refetching, and bundle resubmission as a state machineinvalid noncecode to a bundle submission,SubmitFutwill fetch a new nonce from the sequencer and resubmit the bundle under the new nonce.AbciCode::from_cometbftadded to convert fromtendermint::abci::Codestartup_guards that are awaited to make sure the startup query guards are only matched in the beginning.Testing
Related Issues
Link any issues that are related, prefer full github links.
closes #293
closes #307