chore(conductor): implement clippy pedantic suggestions #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noot
approved these changes
Nov 10, 2023
joroshiba
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement all clippy pedantic suggestions for conductor, activate in CI.
Background
These changes were made for consistency. All repositories should be checked with clippy pedantic.
Changes
cargo clippy -- -W clippy::pedantic, fix all nagsastria-conductorfrom the--excludelist in the clippy CI.typesmodule, move it underexecutoranddata_availability, where they are more appropriate)-Slim down functions that were too big and unwieldy
Testing
All tests still pass. No extra tests are necessary because no structural refactoring took place.
Related Issues
Closes #570