fix(conductor): validator height should be trailing #613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch extracts Rust types that are used in communication between sequencer, sequencer-relayer, conductor, and celestia (as the data availability layer). The resulting protobuf types are intended to be the only way that services exchange data, making the current json-based wire format obsolete. The protobuf types defined in v1alpha1 of the sequencer API are deprecated (and were also never used). add a builder to astria-merkle for deserialization rename chain_id -> rollup_id remove roots, proofs from protos where appropriate clean-up sequencer-types by removing unused bits fix sequencer-relayer tests by constructing the correct action roots
72b9754 to
7c68c96
Compare
noot
approved these changes
Nov 29, 2023
Contributor
noot
left a comment
There was a problem hiding this comment.
do you want to merge this into main?
Base automatically changed from
superfluffy/sequencer-types-as-protos
to
main
November 30, 2023 01:27
SuperFluffy
added a commit
that referenced
this pull request
Nov 30, 2023
…619) ## Summary Use macros and methods provided by our dependencies to have a more expressive style ## Background tendermint's `Height` type provides `Height::increment`, `eyre::ensure!` allows expressing `if ... { bail!(...) }` in a more semantic way. ## Changes - Fixed some stylistic code choices. ## Testing No logic changes, test still run. ## Related Issues Followup to #613
sgranfield4403-3
added a commit
to sgranfield4403-3/astria
that referenced
this pull request
Oct 2, 2025
…#619)
## Summary
Use macros and methods provided by our dependencies to have a more
expressive style
## Background
tendermint's `Height` type provides `Height::increment`, `eyre::ensure!`
allows expressing `if ... { bail!(...) }` in a more semantic way.
## Changes
- Fixed some stylistic code choices.
## Testing
No logic changes, test still run.
## Related Issues
Followup to astriaorg/astria#613
AngieD101
added a commit
to AngieD101/astria
that referenced
this pull request
Oct 10, 2025
…#619)
## Summary
Use macros and methods provided by our dependencies to have a more
expressive style
## Background
tendermint's `Height` type provides `Height::increment`, `eyre::ensure!`
allows expressing `if ... { bail!(...) }` in a more semantic way.
## Changes
- Fixed some stylistic code choices.
## Testing
No logic changes, test still run.
## Related Issues
Followup to astriaorg/astria#613
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updating to match updated understanding of validator heights.
Background
PR #589 updated to use the trailing validator, since this is the validator set AFTER the block, but this check was not updated so blocks from DA always rejected.
Changes
Testing
CI