refactor(proto): rename astria-proto to astria-core #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8076311 to
4078eb1
Compare
SuperFluffy
commented
Dec 12, 2023
d424190 to
f13d616
Compare
noot
reviewed
Dec 18, 2023
d4b8562 to
86dcae8
Compare
This was referenced Feb 10, 2024
Closed
bharath-123
added a commit
that referenced
this pull request
Mar 7, 2024
…roto (#777) ## Summary astria-proto repo was renamed to astria-core in #644 . This PR addresses the corresponding README changes to change `astria-proto` to `astria-core` ## Background The [https://github.com/astriaorg/astria/tools/protobuf-compiler/README.md](https://github.com/astriaorg/astria/tools/protobuf-compiler/README.md) includes the path which points to where the generated code for the protobufs resides. It points to a stale `astria-proto` link which can be confusing to new developers looking at the codebase. The other README changes come as a result of this observation. ## Changes - Updates to READMEs ## Testing No need of testing ## Metrics No need of metrics ## Breaking Changelist No breaking changes ## Related Issues closes <!-- list any issues closed here -->
bharath-123
added a commit
that referenced
this pull request
Mar 7, 2024
…roto (#777) ## Summary astria-proto repo was renamed to astria-core in #644 . This PR addresses the corresponding README changes to change `astria-proto` to `astria-core` ## Background The [https://github.com/astriaorg/astria/tools/protobuf-compiler/README.md](https://github.com/astriaorg/astria/tools/protobuf-compiler/README.md) includes the path which points to where the generated code for the protobufs resides. It points to a stale `astria-proto` link which can be confusing to new developers looking at the codebase. The other README changes come as a result of this observation. ## Changes - Updates to READMEs ## Testing No need of testing ## Metrics No need of metrics ## Breaking Changelist No breaking changes ## Related Issues closes <!-- list any issues closed here -->
bharath-123
added a commit
that referenced
this pull request
Mar 7, 2024
…roto (#777) ## Summary astria-proto repo was renamed to astria-core in #644 . This PR addresses the corresponding README changes to change `astria-proto` to `astria-core` ## Background The [https://github.com/astriaorg/astria/tools/protobuf-compiler/README.md](https://github.com/astriaorg/astria/tools/protobuf-compiler/README.md) includes the path which points to where the generated code for the protobufs resides. It points to a stale `astria-proto` link which can be confusing to new developers looking at the codebase. The other README changes come as a result of this observation. ## Changes - Updates to READMEs ## Testing No need of testing ## Metrics No need of metrics ## Breaking Changelist No breaking changes ## Related Issues closes <!-- list any issues closed here -->
sgranfield4403-3
added a commit
to sgranfield4403-3/astria
that referenced
this pull request
Oct 2, 2025
…roto (#777) ## Summary astria-proto repo was renamed to astria-core in astriaorg/astria#644 . This PR addresses the corresponding README changes to change `astria-proto` to `astria-core` ## Background The [https://github.com/astriaorg/astria/tools/protobuf-compiler/README.md](https://github.com/astriaorg/astria/tools/protobuf-compiler/README.md) includes the path which points to where the generated code for the protobufs resides. It points to a stale `astria-proto` link which can be confusing to new developers looking at the codebase. The other README changes come as a result of this observation. ## Changes - Updates to READMEs ## Testing No need of testing ## Metrics No need of metrics ## Breaking Changelist No breaking changes ## Related Issues closes <!-- list any issues closed here -->
AngieD101
added a commit
to AngieD101/astria
that referenced
this pull request
Oct 10, 2025
…roto (#777) ## Summary astria-proto repo was renamed to astria-core in astriaorg/astria#644 . This PR addresses the corresponding README changes to change `astria-proto` to `astria-core` ## Background The [https://github.com/astriaorg/astria/tools/protobuf-compiler/README.md](https://github.com/astriaorg/astria/tools/protobuf-compiler/README.md) includes the path which points to where the generated code for the protobufs resides. It points to a stale `astria-proto` link which can be confusing to new developers looking at the codebase. The other README changes come as a result of this observation. ## Changes - Updates to READMEs ## Testing No need of testing ## Metrics No need of metrics ## Breaking Changelist No breaking changes ## Related Issues closes <!-- list any issues closed here -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Renames
astria-prototoastria-core.Background
Originally
astria-protocontained the astria protobuf specs and the Rust types to interact with them. Since then the protobuf specs have moved to their own root-level directory and the crate contains more idiomatic types and methods.This PR contains no logic changes.
Changes
astria-prototoastria-coreastria-core/src/generatedastria-core/src/native(formerlyastria-proto/src/native), moving all its definitions underastria-core/srcTesting
All tests are still running after adapting the imports