refactor(api): define abci error codes in protobuf #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57f9c5b to
12ba88f
Compare
0db7eac to
d9273c1
Compare
SuperFluffy
commented
Dec 12, 2023
| ABCI_ERROR_CODE_INVALID_PARAMETER = 2; | ||
| ABCI_ERROR_CODE_INTERNAL_ERROR = 3; | ||
| ABCI_ERROR_CODE_INVALID_NONCE = 4; | ||
| ABCI_ERROR_CODE_TRANSACTION_TOO_LARGE = 5; |
Contributor
Author
There was a problem hiding this comment.
@noot I renamed this from INVALID_SIZE to make it slightly more specific/descriptive.
SuperFluffy
commented
Dec 12, 2023
| /// This hashes each item before pushing it into the Merkle Tree, which | ||
| /// effectively causes a double hashing. The leaf hash of an item `d_i` | ||
| /// is then `MTH(d_i) = SHA256(0x00 || SHA256(d_i))`. | ||
| fn merkle_tree_from_transactions<I, B>(iter: I) -> merkle::Tree |
Contributor
Author
There was a problem hiding this comment.
no code changes here. Just moved this out of the sequencer-types crate as this was only used in conductor.
5f78d67 to
419028f
Compare
e909954 to
585fe66
Compare
419028f to
f454bd4
Compare
585fe66 to
ee36c7c
Compare
ee36c7c to
0a86d37
Compare
97dd791 to
f141fda
Compare
Base automatically changed from
superfluffy/restructure-sequencer-api-code
to
main
December 19, 2023 11:18
0a86d37 to
c6538c1
Compare
sambukowski
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Define protobuf spec for ABCI error codes, remove sequencer-types crate.
Background
All public APIs should be defined in
astria-apiand the protobuf spec. This patch allows non-rust code to understand the abci codes emitted by sequencer.The abci return code convention of having
0be success and non-zero be an error does not cleanly map to the protobuf convention. Protobuf enums should have a default valueUNSPECIFIED = 0. We therefore go with the protobuf convention and define the enum type asAbciErrorCode.Changes
Testing
Tests making use of abci codes still work.
Related Issues
closes #369