fix(sequencer): set current app hash properly when creating app #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joroshiba
reviewed
Apr 30, 2024
| pub(crate) async fn new(snapshot: Snapshot) -> anyhow::Result<Self> { | ||
| tracing::debug!("initializing App instance"); | ||
|
|
||
| let app_hash: AppHash = snapshot |
Member
There was a problem hiding this comment.
will this fail if init_chain has not been called yet?
Contributor
Author
There was a problem hiding this comment.
no, it'll just return the root hash of an empty tree. confirmed that syncing from genesis with an empty state works
joroshiba
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
set current app hash properly when creating app
Background
this was causing issues if the node was restarted as the app hash would be empty, and this is written to state in ibc begin_block, causing an app hash mismatch on the next synced block
Changes
Testing
local testnet with 4 validators and restarting one node, previously failed, now it works