chore(sequencer-relayer): change compression ratio calculation #1075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperFluffy
approved these changes
May 15, 2024
Contributor
SuperFluffy
left a comment
There was a problem hiding this comment.
Looks good. I think we can forego the unit test altogether because a) the compression ratio can actually be smaller 1, and b) this code is just a visual crutch.
crates/astria-sequencer-relayer/src/relayer/write/conversion.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Inverts the compression ratio calculation.
Background
It's normal to express a compression ratio as uncompressed:compressed, but were reporting it as the inverse of this in logs and metrics (despite the metric's description claiming it was uncompressed:compressed).
Changes
As per summary.
Testing
Added a unit test.
Metrics
No new metric added, but the value of
astria_sequencer_relayer_compression_ratio_for_astria_blockshould now generally be > 1 rather than < 1.