Skip to content

chore(cli): return Bech32m Prefixed Address #1621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quasystaty1 merged 2 commits into from
Oct 22, 2024
Merged

chore(cli): return Bech32m Prefixed Address #1621

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af3cf26
prints bech32m address
quasystaty1 Oct 3, 2024
18e93c5
remove ArgsCrate, use try_address
quasystaty1 Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions crates/astria-cli/src/sequencer/account.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,19 +40,18 @@ enum SubCommand {
}

#[derive(Debug, clap::Args)]
struct Create;
struct Create {
/// The address prefix
#[arg(long, default_value = "astria")]
prefix: String,
}

impl Create {
#[expect(
clippy::unused_self,
clippy::unnecessary_wraps,
reason = "for consistency with all the other commands"
)]
fn run(self) -> eyre::Result<()> {
let signing_key = SigningKey::new(OsRng);
let pretty_signing_key = hex::encode(signing_key.as_bytes());
let pretty_verifying_key = hex::encode(signing_key.verification_key().as_bytes());
let pretty_address = hex::encode(signing_key.address_bytes());
let pretty_address = SigningKey::try_address(&signing_key, &self.prefix)?;
println!("Create Sequencer Account");
println!();
// TODO: don't print private keys to CLI, prefer writing to file:
Expand Down