Skip to content

Conversation

@SuperFluffy
Copy link
Contributor

@SuperFluffy SuperFluffy commented Nov 29, 2024

Summary

This patch adds the Astria Auctioneer service to the monorepo.

Background

The Astria Auctioneer auctions the top of the next Rollup to the highest bidder.

It receives a proposed Sequencer block1 via a Sequencer node's astria.sequencerblock.optimistic.v1alpha1.OptimisticBlock service, and forwards it to its Rollup node's astria.auction.v1alpha1.OptimisticExecutionService for optimistic execution by the Rollup. The executed optimistic block hash returned by the rollup triggers Auctioneer to start an auction. It then receives bids from the Rollup node's astria.auction.v1alpha.AuctionService, selecting the winner using a first-price mechanism.

The auction winner is finally submitted to the same Sequencer node using a standard ABCI broadcast_tx_sync to the Sequencer network.

Auctioneer does not act as a server in its own right but connects as a client to a Rollup node and to a Sequencer node.

Changes

  • Add crate crates/astria-auctioneer. It is implemented as a simple event loop that multiplexes proposed blocks and finalized commits (from sequencer), as well as executed rollup blocks and bids (from the rollup).
  • Bump workspace dependency tokio_utils to 0.7.13 to get access to CancellationToken::run_until_cancelled
  • Rename execution APIs astria.bundle to astria.auction
  • Add domain type SequencerBlockCommit to new astria_core::sequencerblock::optimistic::v1alpha1 submodule, following protobuf spec naming conventions (the other domain types remain exclusive to auctioneer for now).
  • Implement astria_core::Protobuf for FilteredSequencerBlock to get access to the wiretype name in error and log messages.
  • Refactor astria_sequencer::sequencer::start_grpc_server to astria-sequencer::grpc::serve
  • Add module astria_sequencer::grpc::optimistic implementing the astria.sequencerblock.optimistic.v1alpha1.OptimisticBlock gRPC service
  • Refactor astria_sequencer::app module to implement an EventBus that is used by the gRPC service to subscribe to new events (right now, only proposed blocks and commits).
  • Add setting ASTRIA_SEQUENCER_NO_OPTIMISTIC_BLOCKS to toggle the optimistic block service in Sequencer
  • Add chart charts/auctioneer
  • Update charts/evm-rollup/files/genesis/geth-genesis.json to set astriaAuctioneerAddresses
  • Update charts/sequencer/templates/configmaps.yaml to to set ASTRIA_SEQUENCER_NO_OPTIMISTIC_BLOCKS
  • Update justifle to understand how to docker-build auctioneer
  • Add job auctioneer to docker-build github workflow.

Testing

This patch does not contain blackbox tests because there currently is no support in the Rust ecosystem to easily mock streams. Smoke tests to submit a winning bid to sequencer and have it executed against geth will be done in a follow-up PR.

We deployed a local setup consisting of a dedicated auctioneer flame node, the auctioneer node and a sequencer with optimistic blocks enabled.

The code for auctioneer flame node can be found at astriaorg/flame#30. The auctioneer has been tested locally against this auctioneer flame node branch.

We have tested the setup by sending txs to the auctioneer flame node using spamooor. We check with logs and manually query the blocks to ensure that the tx sent has end up on the top of block of the auctioneer.

Metrics

  • astria_auctioneer_block_commitments_received: counter (the number of block commitments auctioneer received from sequencer over its runtime)
  • astria_auctioneer_executed_blocks_received: counter (the number of executed blocks auctioneer received from its connected rollup over its runtime)
  • astria_auctioneer_proposed_blocks_received: counter (the number of proposed blocks auctioneer received from sequencer over its runtime)
  • astria_auctioneer_auctions_cancelled: counter (the auctions auctioneer cancelled over its runtime because a new proposed sequencer block cancelled a previous one and thus the auction; this might include auctions for which sumissions took too long)
  • astria_auctioneer_auctions_submitted: counter (the auctions auctioneer successfully submitted over its runtime)
  • astria_auctioneer_auction_bids_received: counter (total bids received over the runtime of auctioneer)
  • astria_auctioneer_auction_bids: histogram (bids per auction labels "processed" and "dropped")
  • astria_auctioneer_auction_bids_without_matching_auction: counter (the number of bids auctioneer received without having a matching auction running over its runtime; for example because the bid contained a difference sequencer or rollup block hashes than what the auction expected)
  • astria_auctioneer_winner_submission_latency histogram (labels "success" and "error"; time from when an auction started and auctioneer received a bid for the auction)
  • astria_winning_bid: histogram (the amount that the winning bid was willing to pay)

Changelogs

Changelogs updated.

Related Issues

closes #1888
closes #1533
closes #1820

Footnotes

  1. A proposed Sequencer block is that data structure that comes out of the Astria Sequencer network's CometBFT process-proposal step.

@github-actions github-actions bot added conductor pertaining to the astria-conductor crate sequencer pertaining to the astria-sequencer crate labels Dec 2, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation proto pertaining to the Astria Protobuf spec sequencer-relayer pertaining to the astria-sequencer-relayer crate composer pertaining to composer cd labels Dec 5, 2024
@SuperFluffy SuperFluffy changed the base branch from itamarreif/auctioneer/eng-824 to main January 7, 2025 13:15
Copy link
Contributor

@quasystaty1 quasystaty1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infra approval. Note, a test is failing duo to chart dependency issue. run:
helm dependency update ./charts/evm-stack to resolve.

Copy link
Member

@joroshiba joroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for API and infra w/ minor nits on proto naming stuff


import "google/protobuf/any.proto";

message GetBidStreamRequest {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: try to keep the request and return types together in file definition

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in e52c1b9 but then superseded by 000b66c

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again very nit, and we don't do a great job of this elsewhere but I think bid.proto is not a great name for this.

We could do 1-1-1, I'd be generally in favor but this isn't our operating practice to date.

I think service.proto or auction_service.proto would be a reasonable file name here outside of doing that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 000b66c and dfa5fca.

@SuperFluffy SuperFluffy added this pull request to the merge queue Feb 14, 2025
Merged via the queue into main with commit 2db84ed Feb 14, 2025
50 checks passed
@SuperFluffy SuperFluffy deleted the ENG-824/auctioneer branch February 14, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auctioneer cd ci issues that are related to ci and github workflows documentation Improvements or additions to documentation proto pertaining to the Astria Protobuf spec sequencer pertaining to the astria-sequencer crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up names in Bundle API Build auctioneer docker image in CI Astria Auctioneer MVP

9 participants