Fix memory leak in connmanager #1576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@hxw Sorry I missed this one. Looks good. Is there any chance you could rebase this so the CI can run properly and squash to one commit? I think that is all it will need to be good to go. |
jcvernaleo
requested changes
Aug 3, 2021
Member
jcvernaleo
left a comment
There was a problem hiding this comment.
Needs rebase and squash but otherwise looks good.
Contributor
Author
|
Sorry I totally forgot about this, until I rebuild my program last week and I stated getting leaks over the last few days, only just realised what the problem was. I have merged my branch with the current master and will test first. I will then rebase, squash etc. when I have done some testing. |
fix memory leak in connmanager caused by: * pending entries are not removed on error * new connection always allocates new struct * capture id value for callback Fix by calling Remove in both handleFailedConn callbacks to delete the item from the pending hash map Signed-off-by: Christopher Hall <hsw@bitmark.com>
Pull Request Test Coverage Report for Build 3889135262
💛 - Coveralls |
Pull Request Test Coverage Report for Build 3889598567
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of an error the connection struct is never deleted from the pending hash map.
In some testing I observed leaks of 3MB in an hour
The problem stem from the fact that the handleFailedConn does not reuse the connect but allocate a new one