Skip to content

btcjson: Update fields in GetNetworkInfoResult #1800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2022
Merged

btcjson: Update fields in GetNetworkInfoResult #1800

merged 1 commit into from
Apr 9, 2022

Conversation

@dekokun
Copy link
Contributor

@dekokun dekokun commented Jan 31, 2022 •
edited
Loading

Update the fields of GetNetworkInfoResult to reflect the current number of inbound and outbound peer connections.

  • ConnectionsIn - The number of inbound peer connections
  • ConnectionsOut - The number of outbound peer connections

ref: bitcoin/bitcoin#19405
release note: https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-0.21.0.md#updated-rpcs

getnetworkinfo now returns two new fields, connections_in and connections_out, that provide the number of inbound and outbound peer connections. These new fields are in addition to the existing connections field, which returns the total number of peer connections. (#19405)

@dekokun dekokun changed the title btcjson: Update GetNetworkInfoResult. btcjson: Update fields in GetNetworkInfoResult. Jan 31, 2022
@dekokun dekokun force-pushed the add-connections-in-out-field-to-getnetworkinforesult branch from db9dba6 to 3470aec Compare January 31, 2022 13:15
btcjson: Update the fields of GetNetworkInfoResult
da8f03b 
Update the fields of GetNetworkInfoResult to reflect the current number
of inbound and outbound peer connections.

* ConnectionsIn - The number of inbound peer connections
* ConnectionsOut - The number of outbound peer connections
@dekokun dekokun force-pushed the add-connections-in-out-field-to-getnetworkinforesult branch from 3470aec to da8f03b Compare January 31, 2022 13:17
@dekokun dekokun changed the title btcjson: Update fields in GetNetworkInfoResult. btcjson: Update fields in GetNetworkInfoResult Feb 1, 2022
@coveralls
Copy link

coveralls commented Feb 7, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1772040973

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.676%
Totals Coverage Status
Change from base Build 1753768655: 0.0%
Covered Lines: 1231
Relevant Lines: 1545
💛 - Coveralls

jcvernaleo
jcvernaleo approved these changes Apr 9, 2022
View reviewed changes
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jcvernaleo jcvernaleo merged commit 796f174 into btcsuite:master Apr 9, 2022
dekokun added a commit to dekokun/mackerel-plugin-bitcoin that referenced this pull request Jun 5, 2022
@dekokun
use connection count in getnetworkinfo instead of getpeerinfo
3294f10 
ref: btcsuite/btcd#1800
@dekokun dekokun mentioned this pull request Jun 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcvernaleo jcvernaleo jcvernaleo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dekokun @coveralls @jcvernaleo