Skip to content

Conversation

@vpereira01
Copy link
Contributor

@vpereira01 vpereira01 commented Feb 22, 2022

With PR #1785 multiple coverage reports are sent to coveralls. This makes coveralls only consider the last report sent. This fix treat all reports has parallel coverage reports so they can all be compiled later by coveralls.

Coverage and after before

@vpereira01 vpereira01 marked this pull request as ready for review February 22, 2022 16:53
With PR btcsuite#1785 multiple coverage reports are sent to coveralls. This
makes coveralls only consider the last report sent. This fix treat all
reports has parallel reports so they can all be compiled later by coveralls.
@vpereira01 vpereira01 force-pushed the FixCoverallCoverage branch from 05237a2 to c36e13a Compare March 7, 2022 20:48
@coveralls
Copy link

coveralls commented Mar 10, 2022

Pull Request Test Coverage Report for Build 1886594031

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-16.6%) to 53.304%

Totals Coverage Status
Change from base Build 1896270968: -16.6%
Covered Lines: 23697
Relevant Lines: 44456

💛 - Coveralls

Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

OK

@jcvernaleo
Copy link
Member

Sorry for the slow response time on this PR. Reviewed and merging it now.

@jcvernaleo jcvernaleo self-assigned this Mar 10, 2022
@jcvernaleo jcvernaleo added the bug label Mar 10, 2022
@jcvernaleo jcvernaleo merged commit 10cff87 into btcsuite:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants