Skip to content

Conversation

@odeke-em
Copy link
Contributor

@odeke-em odeke-em commented May 6, 2022

Courtesy of the Cosmos Network security team, this change
adds a fuzzer to ParsePubKey, given that Tendermint uses
this code.

/cc @elias-orijtech

@Roasbeef
Copy link
Member

Roasbeef commented May 6, 2022

Dependent on #1850

@odeke-em
Copy link
Contributor Author

odeke-em commented May 6, 2022

Dependent on #1850

Indeed, thank you @Roasbeef!

@odeke-em odeke-em force-pushed the fuzz-FuzzParsePubKey branch from 2da7d32 to e773ed3 Compare May 6, 2022 03:33
Courtesy of the Cosmos Network security team, this change
adds a fuzzer to ParsePubKey, given that Tendermint uses
this code.
@odeke-em odeke-em force-pushed the fuzz-FuzzParsePubKey branch from e773ed3 to 4550049 Compare May 6, 2022 03:35
@odeke-em
Copy link
Contributor Author

odeke-em commented May 6, 2022

@Roasbeef I've added build tags to guard against any failures if Go1.18 isn't used, this will allow review and merging of PRs without being affected by test failures.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2279561176

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.004%) to 55.005%

Files with Coverage Reduction New Missed Lines %
connmgr/connmanager.go 2 86.79%
txscript/taproot.go 2 95.93%
Totals Coverage Status
Change from base Build 2242543066: -0.004%
Covered Lines: 26158
Relevant Lines: 47556

💛 - Coveralls

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🪁

@Roasbeef Roasbeef merged commit d5eb4e9 into btcsuite:master May 10, 2022
@odeke-em odeke-em deleted the fuzz-FuzzParsePubKey branch November 9, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants