Add ScriptPubKeyResult address field (rpc client & server) #1858
+13
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2354956596
💛 - Coveralls |
|
Any update on this? would be great to merge this in |
qhxcWallet
approved these changes
Nov 28, 2022
qhxcWallet
left a comment
There was a problem hiding this comment.
The changes here apply to the v22 version of Bitcoin core
qhxcWallet
approved these changes
Nov 28, 2022
kgpark1399
approved these changes
Feb 15, 2023
Contributor
Author
|
Better to use #1969 because with this PR a multisig script might look like a normal address in RPC response |
Pull Request Test Coverage Report for Build 2354956596Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
addressfield toScriptPubKeyResult. Deprecateaddressesfield.This conforms to the corresponding change in Bitcoin Core:
In Bitcoin Core a configuration flag is required to keep serving
addresses. This PR serves both for the time being. The reason to require a configuration change is likely to incentivise adoption of the new field. I don't see that being as necessary forbtcd.