make: add install and release-install goals #1890
Conversation
Pull Request Test Coverage Report for Build 3138652193Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
| btcutil/psbt/coverage.txt | ||
|
|
||
| # Binaries produced by "make build" | ||
| /addblock |
There was a problem hiding this comment.
Is the path here right? Why /addblock and not just addblock?
There was a problem hiding this comment.
AFAIK /addblock will match any file or directory that is located in the root directory of the repository, while addblock will match any file or directory in any directory within the repository. It will match both files and directories with that name, meaning it would patternmatch more than just the generated binaries. (if they wouldn't have been comitted already)
jcvernaleo
left a comment
There was a problem hiding this comment.
Yep, rebase and good to go.
The use of the GO111MODULE environment variable doesn't have any effect anymore and hasn't for a couple of versions. The default was set to "on" a while back, so we can remove that variable everywhere.
To simplify building the release-grade (stripped and reproducible) binaries from source, we add the install and release-install make goals. Running either of the commands will create binaries in the $GOPATH/bin directories. The main difference between the two goals is that the release-install will not contain any local paths and no debug information.
5ccb7be to
ce3ca97
Compare
|
Rebased. |
To simplify building the release-grade (stripped and
reproducible) binaries from source, we add the install and
release-install make goals. Running either of the commands will create
binaries in the $GOPATH/bin directories.
The main difference between the two goals is that the release-install
will not contain any local paths and no debug information.