Skip to content

Conversation

@jagottsicher
Copy link
Contributor

minor changes to increase readability (easier copying) and a typo (echo needs double quotes if you want to add with >> append it to a file)

minor changes to increase readability and a typo (echo need double quotes if adding to a file)
@coveralls
Copy link

coveralls commented Jan 18, 2023

Pull Request Test Coverage Report for Build 3949044169

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 55.149%

Totals Coverage Status
Change from base Build 3903303371: 0.005%
Covered Lines: 26559
Relevant Lines: 48159

💛 - Coveralls

Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like fixing the copy and paste part but I don't think the double quotes on line two are needed unless I'm missing something.

Implemented in pull request btcsuite#1938 requested change. Removed mistakenly added quotes.
@jagottsicher
Copy link
Contributor Author

put the quotes in again, commmited, and this pull request caught it.

Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jcvernaleo
Copy link
Member

Once the github actions finish running I'll merge.

@jcvernaleo jcvernaleo merged commit 016b3ad into btcsuite:master Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants