Convert witnessToHex into a method ToHexStrings on TxWitness
#1991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8420439676Details
💛 - Coveralls |
ce89bf6 to
f96021d
Compare
guggero
reviewed
Nov 27, 2023
Collaborator
guggero
left a comment
There was a problem hiding this comment.
Thanks for the PR. I think we should just have the helper method (ToHexStrings() and perhaps a ParseWitness() function) but skip the JSON (un)marshal support (see inline comment for the reason).
ToHexStrings to TxWitness
ToHexStrings to TxWitnesswitnessToHex a method ToHexStrings on TxWitness
f96021d to
c5de509
Compare
Contributor
Author
|
I've reduced the scope of this PR to just converting |
c5de509 to
75fe7e4
Compare
witnessToHex a method ToHexStrings on TxWitnesswitnessToHex into a method ToHexStrings on TxWitness
guggero
approved these changes
Mar 25, 2024
Collaborator
guggero
left a comment
There was a problem hiding this comment.
Very nice, LGTM 🎉
Something that's also on my wish list is a simple Serialize() ([]byte, error) method for TxWitness, if you feel like adding that as well (new PR or this one, your call).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a method
ToHexStringstoTxWitness. Remove stand alone functionwitnessToHex(witness wire.TxWitness) []string.Motivation:
witnessToHexis hard to access and to find.