rpcclient: add detailed error types #2138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8328968456Details
💛 - Coveralls |
b0e800d to
9df62a9
Compare
ziggie1984
approved these changes
Mar 17, 2024
Contributor
ziggie1984
left a comment
There was a problem hiding this comment.
LGTM, just had a few Nits regarding the comments otherwise straightforward PR.
rpcclient/errors.go
Outdated
| // `sendrawtransaction` with missing inputs. | ||
| ErrMissingInputsOrSpent BitcoindRPCErr = iota | ||
|
|
||
| // ErrMissingInputs is returned when calling `sendrawtransaction` with |
Contributor
There was a problem hiding this comment.
Nit: :s/ErrMissingInputs/ErrMaxBurnExceeded/g
rpcclient/errors.go
Outdated
| // A timelocked transaction. | ||
| "transaction is not finalized": "non-final", | ||
| "tried to spend coinbase transaction output": "non-final", | ||
| // Minimally-small transaction(in non-witness bytes) that is allowed. |
Contributor
There was a problem hiding this comment.
Nit: Is the comment correct ?
Collaborator
Author
There was a problem hiding this comment.
yeah totally wrong🤦🏻 now fixed
| // Get the error string and turn it into lower case. | ||
| btcErr := strings.ToLower(err.Error()) | ||
| // Error implements the error interface. It returns the error message defined | ||
| // in `bitcoind`. |
Contributor
There was a problem hiding this comment.
should we link the bitcoind code file for the specific error string ?
Collaborator
Author
There was a problem hiding this comment.
updated the comments! Think we need to find a way to automatically create these errors, maybe parsing the package https://github.com/bitcoin/bitcoin/tree/master/test/functional
9df62a9 to
1e41068
Compare
This commit adds detailed errors for all possible errors returned from `sendrawtransaction` or `testmempoolaccept`, enabling upstream callers to have refined control over the actions to be taken.
This commit changes the `RejectReason` resulted from calling btcd's `testmempoolaccept` to be un-matched, leaving it to the caller to decide when and where to match it.
1e41068 to
8abf969
Compare
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds detailed error types so the caller can use the structured errors to gain finer control, eg, handling an error resulted from an RBF attempt.