btcjson: turn warnings into StringOrArray type #2245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ziggie1984. |
Pull Request Test Coverage Report for Build 10668259914Details
💛 - Coveralls |
ziggie1984
approved these changes
Sep 2, 2024
btcjson/chainsvrresults.go
Outdated
| // of the chain backend. | ||
| type StringOrArray []string | ||
|
|
||
| // MarshalJSON implements the json.Marshaler interface |
There was a problem hiding this comment.
Nit: missing point at the end.
There was a problem hiding this comment.
Oops, that's what I get for copy/pasting code... Fixed.
Fixes btcsuite#2224 and lightningnetwork/lnd#9053. Depending on the version of Bitcoin Core, the "warnings" field in the response to getnetworkinfo is either a single string value or an array of strings. We can easily parse those two variants with a custom type that implements an UnmarshalJSON method.
890e562 to
ed879ea
Compare
|
I think we can't just update to a newer Golang version without potentially breaking other projects. See discussion here: #2239 (comment) |
|
cc @Roasbeef would be nice to get this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2224 and lightningnetwork/lnd#9053.
Depending on the version of Bitcoin Core, the "warnings" field in the response to getnetworkinfo is either a single string value or an array of strings.
We can easily parse those two variants with a custom type that implements an UnmarshalJSON method.