refactor: using slices.Contains to simplify the code #2317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Approved CI run. |
Contributor
Author
Sorry, the package cannot be found because the go version used in the current project is too low. This package combination method requires go1.21. Now go1.24 is about to be released. I wonder if the maintainer is interested in updating the go version. |
Collaborator
Signed-off-by: finaltrip <finaltrip@qq.com>
Contributor
Author
|
Updated to the latest code. Please review again. I am curious whether it is necessary to use |
guggero
approved these changes
Feb 12, 2025
Pull Request Test Coverage Report for Build 13289617170Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.