psbt: upgrade dependencies and fix unit test #2375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
approved these changes
May 20, 2025
Collaborator
guggero
left a comment
There was a problem hiding this comment.
Makes sense, thanks for the update/fix.
Member
|
CI isn't running on this for some reason. I also don't see a button to approve the run fro first time contributors. @Aharonee can you force push? |
Upgrade several package versions and fix a test case for transaction serialization.
1a684be to
4727f32
Compare
Contributor
Author
Collaborator
|
Approved CI run |
Pull Request Test Coverage Report for Build 16229198423Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
PSBT module dependencies are out of date. This PR updates them and fixes a unit test that relies on old implementation.
The bug in the unit test was mostly due to the choice to use many sub-modules in this repo, which results in different packages using different versions of the same code, in a way that is less than obvious to contributors.
I will try to address this issue in a future PR.
Steps to Test
To verify the change to the test, simply cherrypick this change only on master branch and run the unit test.
Pull Request Checklist
Testing
Code Style and Documentation
📝 Please see our Contribution Guidelines for further guidance.