Fix show temp#188
Open
fionny-darmawan wants to merge 3 commits into
Open
Conversation
bvaisvil
requested changes
Jun 9, 2026
| temp, | ||
| Span::raw("]"), | ||
| ]; | ||
| spans.extend(temp_spans); |
Owner
There was a problem hiding this comment.
might want to check if temp_spans is empty before attempting to extend the vec
| )), | ||
| ]) | ||
| ]); | ||
| Line::from(spans) |
Owner
There was a problem hiding this comment.
Let's see if we can't add a test for this change, see:
zenith/src/metrics/zprocess.rs
Line 579 in e99775a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Fix CPU title bar showing "TEMP []" when no temperature sensors are present.
The TEMP section is now fully hidden when there are no sensors.
Type of Change
Related Issue
Closes #
Changes
tempfrom a singleSpanto aVec<Span>(temp_spans) thatis conditionally populated. This returns all three spans (label, value,
closing bracket) only when sensors exist, and an empty vec otherwise.
extendso the TEMPsection is completely absent when there are no sensors.
Testing
Previously, the CPU sparkline title bar would render "TEMP []" even when
no sensors were available, which looked wrong.
Platforms tested:
Test steps:
Performance Impact
N/A
Checklist
cargo clippypasses with no new warningscargo testpassescargo fmtappliedunwrap()/expect()without justification in a comment