Fix #124: Allow nameof() expressions in GraphQL query names #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified ResolveName method to accept both string literals and nameof() expressions - Updated error message to reflect that both literals and nameof are accepted - Added test to verify nameof() expressions work correctly - Added test to ensure non-literal/non-nameof expressions are still rejected This resolves the analyzer issue where nameof(methodName) was incorrectly flagged as "GraphQL query name should be literal" 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Added onlyFirstCall parameter to VerifyServiceIsRunning to prevent hanging in tests - Updated PersistentQueryTest to use the new parameter for faster test execution 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
nameof()expressions were incorrectly rejected as query namesResolveNamemethod to accept both string literals andnameof()expressionsnameofare acceptedChanges
ResolveNamemethod to handlenameof()expressionsnameofexpressions are allowednameof()support and test ensuring other expressions are still rejectedTest plan
SupportsNameofQueryNamepasses, verifyingnameof(Execute)worksRejectsNonLiteralNonNameofQueryNamepasses, ensuring other expressions are still rejected🤖 Generated with Claude Code