fix: do not skip wasi:http export processing #218
Conversation
|
Hey @tschneidereit would you mind taking a look at this? it wasn't clear why http was skipped explicitly (testing?), but it breaks builds of components that implement |
tschneidereit
left a comment
There was a problem hiding this comment.
Oh yeah, that's an annoying but—my apologies!
Would you by any chance be up for adding a test for this, so we don't regress it again?
|
Oh yeah great point -- will do that and get it in today! 🙇 |
4f34de8 to
bbc0232
Compare
|
Hey @tschneidereit this is ready for another review -- the tests that are failing intermittently are the |
e301d9b to
ae59b95
Compare
|
Rebasing this to the fetch PR just so we can get green tests. |
tschneidereit
left a comment
There was a problem hiding this comment.
Thank you for all the work you put into the test here, very much appreciated!
519e32e to
af276c0
Compare
This commit removes the ignored handling of `wasi:http/incoming-handler` which breaks components that have manually implemented the `handle` export. Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
af276c0 to
bbf3980
Compare
|
Thanks @tschneidereit ! I've rebased the PR so it's a bit easier to parse out what is what -- Just one commit now! |
This commit removes the ignored handling of
wasi:http/incoming-handlerwhich breaks components that have manually implemented thehandleexport.This change was introduced during the recent overhaul, and I got blocked by this trying to upgrade componentize-js in jco