Implement Component::define_unknown_imports_as_traps
#8672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will search through a components imports, find any imports that have not yet been defined in the linker and add a definition which will trap upon being called.
Member
alexcrichton
left a comment
There was a problem hiding this comment.
Thanks! Could this be written with a recursive helper that operates on a &ComponentType (or similar) and a LinkerInstance? That'll help remove some minor duplication here and additionally handle the fully general case of all component imports.
Additionally could this return an error for unsupported imports? For example this can't fill in the import of a component or import of a module at this time so I think those should return an error rather than being silently ignored.
And finally, mind adding a test or two for this?
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
alexcrichton
approved these changes
May 21, 2024
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Jul 26, 2024
This was implemented in bytecodealliance#8672 and is an easy addition to the CLI. Closes bytecodealliance#9019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8645